Make tuple index constexpr-safe; fix Python Protocol import; tighten XLA typings - #328
Closed
Trinkle23897 wants to merge 2 commits into
Closed
Make tuple index constexpr-safe; fix Python Protocol import; tighten XLA typings#328Trinkle23897 wants to merge 2 commits into
Trinkle23897 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Protocolimport deterministic by checking the running Python version instead of relying on atry/exceptfallback only.Description
Index<T, std::tuple<...>>inenvpool/core/tuple_utils.hto use aconstexpr std::array<bool, ...>scan to computekValue, added#include <array>, and moved thestatic_assertto validate the found index.TupleFromVectorImploverloads intact but consolidated the constexpr indexing logic for clearer behavior and error messages.envpool/python/protocol.pyaddedimport sysand replaced thetry/exceptimport ofProtocolwith a version check that usestyping.Protocolfor Python >= 3.8 andtyping_extensions.Protocolotherwise.envpool/python/xla_template.pyupdated the type annotation forspecstoTuple[Tuple[Any, ...], Tuple[Any, ...]]to reflect variable-length inner tuples and adjusted formatting accordingly.Testing
Codex Task